Skip to content

do not create a location when creating a rating spec#124

Open
adamkorynta wants to merge 2 commits intomainfrom
bugfix/remove_create_location_with_rating_spec
Open

do not create a location when creating a rating spec#124
adamkorynta wants to merge 2 commits intomainfrom
bugfix/remove_create_location_with_rating_spec

Conversation

@adamkorynta
Copy link
Contributor

@adamkorynta adamkorynta commented Mar 10, 2026

instead, throw an ITEM_DOES_NOT_EXIST error

This bug was brought up in: USACE/cwms-data-api#1619

@adamkorynta adamkorynta marked this pull request as ready for review March 11, 2026 21:55
@adamkorynta adamkorynta requested a review from a team March 11, 2026 21:55
@adamkorynta
Copy link
Contributor Author

@HydrologicEngineeringCenter/cwms-database-devs - these look like flaky tests given the small change footprint

@MikeNeilson
Copy link
Contributor

@HydrologicEngineeringCenter/cwms-database-devs - these look like flaky tests given the small change footprint

The counters yeah, the 2nd one though, that's a bit odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants