Skip to content

feat: add SearchBar to Store on Client #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add SearchBar to Store on Client #1328

wants to merge 3 commits into from

Conversation

biliesilva
Copy link
Contributor

Closes: https://github.com/HyperPlay-Gaming/hyperplay-pm/issues/741

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@biliesilva biliesilva self-assigned this Jul 28, 2025
@biliesilva biliesilva added the PR: Ready-For-Review PR is ready to be reviewed by peers label Jul 28, 2025
@biliesilva biliesilva changed the title feat: add SearchBarDiscover component and integrate into TopNavBar feat: add SearchBar to Store on Client Jul 28, 2025
BrettCleary
BrettCleary reviewed Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a bit nitpicky but I think we should simplify the code and approach here a bit

@biliesilva biliesilva added blocked and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Aug 1, 2025
@biliesilva biliesilva added PR: Ready-For-Review PR is ready to be reviewed by peers and removed blocked labels Aug 8, 2025
@biliesilva biliesilva requested a review from BrettCleary August 8, 2025 11:33
@biliesilva biliesilva removed the request for review from eliobricenov August 25, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyuu-jin jiyuu-jin jiyuu-jin approved these changes

@BrettCleary BrettCleary Awaiting requested review from BrettCleary

At least 2 approving reviews are required to merge this pull request.

Assignees

@biliesilva biliesilva

Labels
PR: Ready-For-Review PR is ready to be reviewed by peers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biliesilva @jiyuu-jin @BrettCleary