Skip to content

Move save to log_status_update so e-mail get sent. #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wes-otf merged 2 commits into from
Feb 5, 2026
Merged

Move save to log_status_update so e-mail get sent. #4693

wes-otf merged 2 commits into from
Feb 5, 2026
+14 −23

Conversation

@frjo
Copy link
Member

@frjo frjo commented Feb 5, 2026 •
edited
Loading

Fixes #4692

Test Steps

  • Test that notification go out to reviewers. Slack for internal and e-mail for external.
  • Test that status updated go out via e-mail to applicant and look ok when a submission is moved forward.

@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter labels Feb 5, 2026
@frjo frjo mentioned this pull request Feb 5, 2026
Closed
@frjo frjo requested review from frankduncan and wes-otf February 5, 2026 08:37
@frjo frjo mentioned this pull request Feb 5, 2026
Open
@frankduncan
Copy link
Contributor

frankduncan commented Feb 5, 2026

LGTM! Thanks for the quick turnaround :)

wes-otf
wes-otf approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@wes-otf wes-otf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! works great!

@wes-otf wes-otf merged commit 916e9cf into main Feb 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wes-otf wes-otf wes-otf approved these changes

@frankduncan frankduncan Awaiting requested review from frankduncan

Assignees

No one assigned

Labels

Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Email not sent to reviewers when processing to External Review status

3 participants

@frjo @frankduncan @wes-otf