Remove redundant decorators on individual @overloads
#4564
Conversation
|
Oh woops, vscode seems to have messed up the formatting; sorry about that. |
|
( |
jorenham
force-pushed
the
@overload-decorators
branch
from
5a0eef2 to
3162024
Compare
|
Does this require a release note? |
|
yeah, since we cut a release on every merged PR*. You can put something as simple as "clean up internal *with source code changes |
Co-authored-by: Liam DeVoe <[email protected]>
|
Thanks Joren, this looks great! I'll be curious to follow along on the mypy issue for the root cause, though it's not too surprising they assumed users wouldn't apply weird transformations on top of I think CI is still a bit flaky, it's not your fault. |
|
re: https://github.com/HypothesisWorks/hypothesis/actions/runs/18502481240/job/52723140081?pr=4564
Not sure why it only errors on our free-threading CI job. I'll fix this soon |
|
Thanks! |
2 participants
For some reason this is causing stubtest to crash when running it on the numpy codebase while hypothesis is installed. I'm not saying this is your fault or anything, and I'll report this issue at mypy later today, But even so, there are some other reasons for removing these decorators, so I figured I might as well clean it up.
Decorating a function has a (slight) inpact on import time, so by removing these redundant decorators, importing this module will be slightly faster.
There are also some other obvious reasons, such as readability, maintainability, seeing as it's more "DRY" this way.