Refactor/reduce complexity #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency - Extract daily load calculation into internal helper (R/internal_load.R) - Refactor calculate_acwr() to use calculate_daily_load_internal() - Refactor calculate_exposure() to use the same helper - Add validate_load_metric_params() for centralized validation - Remove viridis from Imports (DESCRIPTION, NAMESPACE, codemeta.json) - Remove @importFrom viridis from plot_exposure.R Addresses reviewer comments on: 1. High cyclomatic complexity in core functions 2. Unused viridis package dependency Public API unchanged - no documentation updates needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses reviewer feedback on code quality and package hygiene.
Relates to: ropensci/software-review#728 (comment)
Changes
1. Reduced Cyclomatic Complexity
calculate_acwr()andcalculate_exposure()now usecalculate_daily_load_internal()validate_load_metric_params()for centralized validation2. Removed Unused Dependency
viridisfrom Imports (was declared but never called)3. Fixed R CMD check NOTEs
data-rawandgenerate_plot_examples.Rto.Rbuildignoreplot_with_reference()examples4. Version Bump