Skip to content

Conversation

@aulme
Copy link
Contributor

@aulme aulme commented Mar 19, 2025

Bassic refactorings of CloudEncryptionKeyManager, should not have any changes in behavior:

  1. Removed public from methods that aren't actually public
  2. Moved the only actual public method to the top
  3. Rearranged the logic to be a bit less nested, extracted a few helpers
  4. Broken up really long lines that don't fit on my laptop monitor
  5. Reduced repetition of common test data in the test

@aulme aulme requested a review from abuabraham-ttd March 19, 2025 09:53
@aulme aulme merged commit c87755b into main Mar 20, 2025
4 checks passed
@aulme aulme deleted the aul-UID2-5175-preliminary-refactoring branch March 20, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants