Using human readable dates #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulme
force-pushed
the
aul-UID2-5175-human-readable-dates-in-encryption-key-list
branch
from
37638f0 to
46e0503
Compare
gmsdelmundo
reviewed
Mar 21, 2025
| ); | ||
| } | ||
|
|
||
| private static String toIsoTimestamp(Long epochSeconds) { |
Contributor
There was a problem hiding this comment.
Can we extract this to a repo-level util method? Might be useful for other pages as well in the future
Contributor
Author
There was a problem hiding this comment.
Let's do that when we actually have the 2nd use case. YAGNI.
Contributor
There was a problem hiding this comment.
Yeah I was thinking we can reuse this for the salts and encryption keys tabs
Contributor
There was a problem hiding this comment.
But fair enough, we can just refactor it out once we start working on other stuff
Contributor
Author
There was a problem hiding this comment.
When we do that enhancement, we can move this to some utils.
gmsdelmundo
approved these changes
Mar 21, 2025
aulme
deleted the
aul-UID2-5175-human-readable-dates-in-encryption-key-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.