Preliminary refactoring #456
Conversation
aulme
force-pushed
the
aul-UID2-5351-preliminary-refactoring
branch
from
cf0b716 to
292f75a
Compare
aulme
force-pushed
the
aul-UID2-5351-preliminary-refactoring
branch
from
292f75a to
45b0e87
Compare
| import static org.mockito.ArgumentMatchers.*; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| public class SaltRotationTest { |
There was a problem hiding this comment.
You can put this class-level annotation:
@ExtendWith(MockitoExtension.java)
Then you won't need to do MockitoAnnotations.openMocks(this); in setup()
If the test fails because the stubs are too lenient, you can additionally add this class-level annotation:
@MockitoSettings(strictness = Strictness.LENIENT)
There was a problem hiding this comment.
This would require importing some new libraries. I suggest we keep this for a separate PR.
|
|
||
| for (int i = 0; i < oldSalts.length; i++) { | ||
| var shouldRotate = saltIndexesToRotate.contains(i); | ||
| updatedSalts[i] = updateSalt(oldSalts[i], shouldRotate, nextEffective); |
There was a problem hiding this comment.
Can we just skip the function call if !shouldRotate and set updatedSalts[i] = oldSalts[i]?
There was a problem hiding this comment.
We can, but the whole point of this refactoring is to prepare for updating refreshFrom. We're planning to always calculate refreshFrom so we'd need to cycle through every salt.
There was a problem hiding this comment.
And we'll also need to update the previous from salt in here too
aulme
merged commit 5a743f8
into
sch-UID2-5350-rotate-salts-at-utc-midnight
No description provided.