Skip to content

sch-UID2-5450 added log line for when salt rotation is complete #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophia-chen-ttd merged 4 commits into from
May 29, 2025
Merged

sch-UID2-5450 added log line for when salt rotation is complete #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58c8cb8
added log line for when salt rotation is complete
sophia-chen-ttd May 28, 2025
8680957
updated salt rotation logging test
sophia-chen-ttd May 28, 2025
324a79d
updated log line
sophia-chen-ttd May 29, 2025
cab8506
updated log line in test
sophia-chen-ttd May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/uid2/admin/salt/SaltRotation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public Result rotateSalts(

var postRotationSalts = rotateSalts(preRotationSalts, saltsToRotate, targetDate);

LOGGER.info("Salt rotation complete target_date={}", targetDate);
logSaltAges("refreshable-salts", targetDate, refreshableSalts);
logSaltAges("rotated-salts", targetDate, saltsToRotate);
logSaltAges("total-salts", targetDate, Arrays.asList(postRotationSalts));
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/uid2/admin/salt/SaltRotationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ void logsSaltAgesOnRotation() throws Exception {
.build();

var expected = Set.of(
"[INFO] Salt rotation complete target_date=2025-01-01",
// Post-rotation ages, we want to look at current state
"[INFO] salt_count_type=total-salts target_date=2025-01-01 age=0 salt_count=2", // The two rotated salts, used to be 65 and 50 days old
"[INFO] salt_count_type=total-salts target_date=2025-01-01 age=5 salt_count=1",
Expand Down