validate link_id's against per-service regex #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return roles; | ||
| } | ||
|
|
||
| private boolean validateLinkIdAgainstServiceRegex(String linkId, String serviceRegex) { |
Contributor
Author
There was a problem hiding this comment.
yeah that sounds good
Base automatically changed from
ian-UID2-3134-add-link-id-regex-field-to-services
to
main
June 18, 2025 03:55
mcollins-ttd
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates link_id against a regex at the time of service creation. This can help prevent input errors
This PR is dependent on: