Skip to content

update metrics naming standards #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizk886 merged 1 commit into from
Jul 1, 2025
Merged

update metrics naming standards #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/uid2/admin/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ private static void setupMetrics(MicrometerMetricsOptions metricOptions) {
// retrieve image version (will unify when uid2-common is used)
String version = Optional.ofNullable(System.getenv("IMAGE_VERSION")).orElse("unknown");
Gauge appStatus = Gauge
.builder("app.status", () -> 1)
.builder("app_status", () -> 1)
.description("application version and status")
.tags("version", version)
.register(Metrics.globalRegistry);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/uid2/admin/job/JobDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public JobDispatcher(
this.maxRetries = maxRetries;
this.clock = clock;

Gauge.builder("uid2.job_dispatcher.execution_duration_ms", this::getExecutionDuration)
Gauge.builder("uid2_job_dispatcher_execution_duration_ms", this::getExecutionDuration)
.tag("job_dispatcher", id)
.description("gauge for " + id + " execution time")
.register(Metrics.globalRegistry);
Expand Down