sch-UID2-5444 added feature switch for default min ages in salt rotation #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulme
reviewed
Jul 14, 2025
| this.storageManager = storageManager; | ||
| this.saltProvider = saltProvider; | ||
| this.saltRotation = saltRotation; | ||
| this.defaultSaltRotationAgeThresholds = generateThresholds(30, 390, 30); |
Contributor
There was a problem hiding this comment.
Honestly I think having this calculated may be an overkill, we can just have the array hardcoded here or in generateThresholds. It would be both clearer, easier to change and require less tests.
aulme
reviewed
Jul 14, 2025
| final Duration[] minAges = RequestUtil.getDurations(rc, "min_ages_in_seconds"); | ||
| if (minAges == null) return; | ||
|
|
||
| final Duration[] ageThresholds; |
Contributor
There was a problem hiding this comment.
Let's log what thresholds we ended up using
gmsdelmundo
reviewed
Jul 14, 2025
| private final SaltStoreWriter storageManager; | ||
| private final RotatingSaltProvider saltProvider; | ||
| private final SaltRotation saltRotation; | ||
| private final Duration[] defaultSaltRotationAgeThresholds; |
Contributor
There was a problem hiding this comment.
You can directly just set this variable to be a static final
e.g.
private static final Duration[] SALT_ROTATION_AGE_THRESHOLDS = generateThresholds(30, 390, 30);or
private static final Duration[] SALT_ROTATION_AGE_THRESHOLDS = new Duration[] { ... };
Contributor
There was a problem hiding this comment.
If you do the former, remember to make generateThresholds() a static function
aulme
approved these changes
Jul 16, 2025
gmsdelmundo
approved these changes
Jul 16, 2025
sophia-chen-ttd
deleted the
sch-UID2-5444-hardcode-salt-rotation-min-ages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: