Skip to content

Remove old participant #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cYKatherine merged 2 commits into from
Apr 10, 2025
Merged

Remove old participant #88

cYKatherine merged 2 commits into from
Apr 10, 2025

Conversation

@cYKatherine
Copy link
Contributor

@cYKatherine cYKatherine commented Apr 9, 2025

No description provided.

@cYKatherine cYKatherine self-assigned this Apr 9, 2025
@cYKatherine cYKatherine force-pushed the kcc-fix-optout-token-e2e branch 4 times, most recently from ac6d188 to 56af989 Compare April 9, 2025 22:54
cYKatherine
cYKatherine commented Apr 9, 2025
View reviewed changes
src/test/java/app/component/Operator.java
}
}

public JsonNode v2TokenGenerateUsingPayload(String payload, boolean asOldParticipant) throws Exception {
Copy link
Contributor Author

@cYKatherine cYKatherine Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used, removed

@cYKatherine cYKatherine force-pushed the kcc-fix-optout-token-e2e branch from a8498ce to 8e4412b Compare April 10, 2025 03:06
@gmsdelmundo
Copy link
Collaborator

gmsdelmundo commented Apr 10, 2025

If we're removing old participant, should we also remove it from the configs? So basically:

  1. In Const.java, remove CLIENT_API_KEY_BEFORE_OPTOUT_CUTOFF and CLIENT_API_SECRET_BEFORE_OPTOUT_CUTOFF
  2. Do the same in Dockerfile with UID2_OPERATOR_E2E_CLIENT_API_KEY_BEFORE_OPTOUT_CUTOFF and UID2_OPERATOR_E2E_CLIENT_API_SECRET_BEFORE_OPTOUT_CUTOFF
  3. In uid2-shared-actions repo, we can also remove these two from any scripts call the uid2-e2e suites

I can help update our uid2-operator pipeline run configs to not include these once the above 3 are done

gmsdelmundo
gmsdelmundo reviewed Apr 10, 2025
View reviewed changes
@cYKatherine cYKatherine force-pushed the kcc-fix-optout-token-e2e branch from 0abaa29 to 48498a4 Compare April 10, 2025 03:16
@cYKatherine cYKatherine merged commit 515590d into main Apr 10, 2025
4 checks passed
@cYKatherine cYKatherine deleted the kcc-fix-optout-token-e2e branch April 10, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmsdelmundo gmsdelmundo gmsdelmundo approved these changes

Assignees

@cYKatherine cYKatherine

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cYKatherine @gmsdelmundo