environment variable substitution #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.env.sample
Outdated
| @@ -0,0 +1,3 @@ | |||
| UID2_BASE_URL="https://operator-integ.uidapi.com" | |||
| SERVER_PUBLIC_KEY="UID2-X-I-MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEo+jcPlk8GWn3iG0R5Il2cbFQI9hR3TvHxaBUKHl5Vh+ugr+9uLMiXihka8To07ETFGghEifY96Hrpe5RnYko7Q==" | |||
| SUBSCRIPTION_ID="DMr7uHxqLU" | |||
Contributor
There was a problem hiding this comment.
should we update subscription id and server public key variable names to start with UID2 since there will be UID2 and EUID versions of these
| # Set default values if not provided | ||
| export UID2_BASE_URL=${UID2_BASE_URL:-"https://operator-integ.uidapi.com"} | ||
| export SERVER_PUBLIC_KEY=${SERVER_PUBLIC_KEY:-"UID2-X-I-MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEo+jcPlk8GWn3iG0R5Il2cbFQI9hR3TvHxaBUKHl5Vh+ugr+9uLMiXihka8To07ETFGghEifY96Hrpe5RnYko7Q=="} | ||
| export SUBSCRIPTION_ID=${SUBSCRIPTION_ID:-"DMr7uHxqLU"} |
Contributor
There was a problem hiding this comment.
can these variables be reused between here and the .env/.env.sample file?
Contributor
Author
There was a problem hiding this comment.
I made a change to this to have a single source for env variables. We don't want to assume an .env file exists so we need the defaults in here
| export $(cat /tmp/env | xargs) | ||
|
|
||
| # Set default values if not provided | ||
| export UID2_BASE_URL=${UID2_CSTG_BASE_URL:-"https://operator-integ.uidapi.com"} |
Contributor
There was a problem hiding this comment.
should this just be BASE_URL then? and base url everywhere instead of UID2_BASE_URL. its a little weird to have base url start with UID2 but server public key and subscription id don't
ashleysmithTTD
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.