Cbc UI d2 4454 cloud encryption operator #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat's going on with auth
…into cbc-UID2-4454-cloud-encryption-operator
Ian-Nara
reviewed
Nov 26, 2024
src/main/java/com/uid2/operator/reader/RotatingCloudEncryptionKeyApiProvider.java
Show resolved
Hide resolved
Ian-Nara
reviewed
Nov 26, 2024
src/main/java/com/uid2/operator/reader/RotatingCloudEncryptionKeyApiProvider.java
Outdated
Show resolved
Hide resolved
Ian-Nara
reviewed
Nov 26, 2024
src/main/resources/com.uid2.core/test/cloud_encryption_keys/cloud_encryption_keys.json
Show resolved
Hide resolved
thomasm-ttd
reviewed
Dec 3, 2024
src/main/java/com/uid2/operator/reader/RotatingCloudEncryptionKeyApiProvider.java
Show resolved
Hide resolved
…IABTechLab/uid2-operator into cbc-UID2-4454-cloud-encryption-operator
thomasm-ttd
reviewed
Dec 23, 2024
| try { | ||
| JsonArray dataArray = contents.getJsonArray(dataType); | ||
| if (dataArray == null) { | ||
| throw new IllegalArgumentException("No array found in the contents"); |
Contributor
There was a problem hiding this comment.
Would it be useful to include the dataType in the error message?
Ian-Nara
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.