Skip to content

Use correct raw UID version for UID2 UIDOperatorVerticleTest and rename identityV3Enabled to rawUidV3Enabled #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunnywu merged 4 commits into from
Dec 10, 2024
Merged

Use correct raw UID version for UID2 UIDOperatorVerticleTest and rename identityV3Enabled to rawUidV3Enabled #1190

sunnywu merged 4 commits into from
Dec 10, 2024

Conversation

@sunnywu
Copy link
Contributor

@sunnywu sunnywu commented Dec 9, 2024 •
edited
Loading

  1. From an PR earlier, it's now only using Raw UID v3 format for UIDOperatorVerticleTest which is wrong as we still use v2 Raw UID format for UID2 prod.
  2. UIDOperatorVerticleTest was incorrectly using Raw UID Format v3 and fixing it requires fixing one of the unit tests
  3. renamed the variable/method useIdentityV3/identityV3Enabled to useRawUidV3/rawUidV3Enabled to be up to date with latest terminlogies
  4. Improved TokenEncodingTest#testAdvertisingTokenEncodings to tests all combo's of raw UID and ad token versions

@sunnywu sunnywu changed the title Use correct raw UID version for UID2 Use correct raw UID version for UID2 Unit Tests Dec 10, 2024
@sunnywu sunnywu changed the title Use correct raw UID version for UID2 Unit Tests Use correct raw UID version for UID2 UIDOperatorVerticleTest and rename identityV3Enabled to rawUidV3Enabled Dec 10, 2024
@sunnywu sunnywu merged commit b792232 into main Dec 10, 2024
4 checks passed
@sunnywu sunnywu deleted the syw-wrong-identity-version-used branch December 10, 2024 06:16
cYKatherine pushed a commit that referenced this pull request Dec 12, 2024
@sunnywu @cYKatherine
Use correct raw UID version for UID2 UIDOperatorVerticleTest and rena…
e66072c 
…me identityV3Enabled to rawUidV3Enabled (#1190)

* Use correct raw UID version for UID2's UIDOperatorVerticleTest 
* renamed the variable/method useIdentityV3/identityV3Enabled to useRawUidV3/rawUidV3Enabled to be up to date with latest terminlogies
* Improved TokenEncodingTest#testAdvertisingTokenEncodings to tests all combo's of raw UID and ad token versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cYKatherine cYKatherine cYKatherine approved these changes

@jon8787 jon8787 jon8787 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunnywu @cYKatherine @jon8787