Runtime config application #1225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
December 16, 2024 14:35
…tants and config.
…edConfig method rather than storing config
…e in UIDOperatorVerticleTest "identity_token_expires_after_seconds", "max_bidstream_lifetime_seconds", "max_sharing_lifetime_seconds" and "sharing_token_expiry_seconds" now are retrieved from RoutingContext in handlers.
…nfigService Moved validation logic from UIDOperatorVerticle and UIDOperatorService to ConfigValidatorUtil configValidationHandler is set as a config processor for configRetriever in ConfigService
…e UIDOperatorServiceTest
…rticle, Updated UIDOperatorVerticleTest
…datorUtilTest to test handling null values
ConfigService returns a Future when created and takes ConfigRetriever in "create" method "run()" method in Main waits for ConfigService Future to complete before creating UIDOperatorVerticle
Removed use of reflection to access private attributes/methods Removed unnecessary tests Updated remaining tests to inject ConfigRetriever into ConfigService
…ication # Conflicts: # src/main/java/com/uid2/operator/Main.java # src/main/java/com/uid2/operator/service/UIDOperatorService.java
Set http store to optional
Added default value for max_bidstream_lifetime_seconds
ConfigServiceManager handles switching between dynamic and static config StaticConfigService implements IConfigService, serving config from static files
Main creates new ConfigServiceManager instance and injects it into UIDOperatorVerticle Also Added feature flag config value to local-config.json, Made create method static in ConfigServiceManager
Removed ConfigServiceManager from constructor
Allows for switches between static and dynamic config services without having to change UIDOperatorVerticle
ConfigRetriever in Main listens for feature flag changes and publishes to eventbus ConfigServiceManager listens to eventbus and updates DelegatingConfigService active ConfigService
Added tests to verify config changes are reflected in endpoints
static config values are set from main config rather than ConfigService
- removed bootstrap config as a store from ConfigRetrieverFactory
- exclusive config retriever to listen to changes in mounted configmap - listener directly interacts with ConfigServiceManager rather than publishing to EventBus
BehnamMozafari
commented
Jan 15, 2025
|
|
||
| Vertx vertx = createVertx(); | ||
| VertxUtils.createConfigRetriever(vertx).getConfig(ar -> { | ||
| ConfigRetriever configRetriever = VertxUtils.createConfigRetriever(vertx); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ]