Implement keyset key fail-fast feature with 7-day timeout #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Main.java to wire keysetkey verticle callback to shutdown handler - Add Consumer import and overloaded createAndDeployRotatingStoreVerticle method - Update KeyManager to accept keyAvailabilityHandler callback - Call handler on successful/failed key retrieval in getMasterKey/getRefreshKey - Add 7-day timeout parameter to OperatorShutdownHandler constructor - Maintains backward compatibility with existing constructors This enables the operator to shut down after 7 days of consecutive keyset key sync failures, allowing Kubernetes to restart and potentially recover.
lizk886
commented
Oct 14, 2025
clarkxuyang
reviewed
Oct 14, 2025
src/main/java/com/uid2/operator/vertx/OperatorShutdownHandler.java
Outdated
Show resolved
Hide resolved
clarkxuyang
reviewed
Oct 14, 2025
src/main/java/com/uid2/operator/vertx/OperatorShutdownHandler.java
Outdated
Show resolved
Hide resolved
clarkxuyang
reviewed
Oct 14, 2025
src/main/java/com/uid2/operator/vertx/OperatorShutdownHandler.java
Outdated
Show resolved
Hide resolved
clarkxuyang
reviewed
Oct 14, 2025
src/main/java/com/uid2/operator/vertx/OperatorShutdownHandler.java
Outdated
Show resolved
Hide resolved
lizk886
commented
Oct 14, 2025
clarkxuyang
reviewed
Oct 14, 2025
| public void handleKeysetKeyRefreshResponse(Boolean success) { | ||
| if (success) { | ||
| keysetKeyFailureStartTime.set(null); | ||
| lastKeysetKeyFailureLogTime.set(null); |
Contributor
There was a problem hiding this comment.
we can move lastKeysetKeyFailureLogTime encapsulated into logKeysetKeyFailureProgressAtInterval
Contributor
Author
There was a problem hiding this comment.
Clearing lastKeysetKeyFailureLogTime in the "success" branch is for if there was a previous failure followed by recovery, the timer for progress logging will reset. This prevents any cached timing from a past failure from causing premature logs after a successful sync.
Keep these value settings here helps tests where we need consistent log timings.
I did simplify logKeysetKeyFailureProgressAtInterval more by passing in elaspsed
clarkxuyang
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.