process async with polling, no message limit #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
…-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
…-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
…seline' into ian-UID2-6151-add-traffic-filter-class
caroline-ttd
reviewed
Dec 2, 2025
| private final boolean stoppedDueToRecentMessages; | ||
|
|
||
| public DeltaProductionResult(int deltasProduced, int entriesProcessed) { | ||
| public DeltaProductionResult(int deltasProduced, int entriesProcessed, boolean stoppedDueToRecentMessages) { |
Contributor
There was a problem hiding this comment.
Nit: can we add a comment here explaining what stoppedDueToRecentMessages means? We might forget the context after a while.
caroline-ttd
reviewed
Dec 2, 2025
mcollins-ttd
reviewed
Dec 3, 2025
Comment on lines
+15
to
+18
| private volatile JobState state; | ||
| private volatile JsonObject result; | ||
| private volatile String errorMessage; | ||
| private volatile Instant endTime; |
Contributor
Author
There was a problem hiding this comment.
State is read from the event loop thread and is written from the (single possible) worker thread caused by execute blocking.
The event loop just reads the status occasionally; the worker thread can write to it.
Contributor
Author
There was a problem hiding this comment.
job.encode() to send the response is in the status handler, and job.complete(result) is in the blocking, worker thread code.
…-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
…seline' into ian-UID2-6151-add-traffic-filter-class
caroline-ttd
approved these changes
Dec 5, 2025
…-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
…seline' into ian-UID2-6151-add-traffic-filter-class
…ter-class add traffic filter class
…calculator-to-hardcoded-baseline traffic calculator with hardcoded baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New :
Modified: