add traffic filter class #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian-Nara
changed the base branch from
main
to
ian-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
…seline' into ian-UID2-6151-add-traffic-filter-class
Ian-Nara
force-pushed
the
ian-UID2-6151-add-traffic-filter-class
branch
from
860e164 to
458d70a
Compare
caroline-ttd
reviewed
Dec 4, 2025
| } | ||
| } | ||
|
|
||
| public boolean isBlacklisted(SqsParsedMessage message) { |
Contributor
There was a problem hiding this comment.
We probably need to change to deny list.
caroline-ttd
reviewed
Dec 4, 2025
| } | ||
|
|
||
| @Test | ||
| public void testIsBlacklisted_atRangeBoundaries() throws Exception { |
Contributor
There was a problem hiding this comment.
Probably deny list. Same as other test name
caroline-ttd
reviewed
Dec 4, 2025
| } | ||
|
|
||
| @Test | ||
| public void testIsBlacklisted_nullClientIp() throws Exception { |
Contributor
There was a problem hiding this comment.
When would a request not contain a client IP?
Should we log an error if no IP is present after processing the request? And set up an alert if there are too many?
caroline-ttd
reviewed
Dec 4, 2025
caroline-ttd
reviewed
Dec 4, 2025
| // log error and throw exception if rule is invalid | ||
| if (range.size() != 2 || ipAddresses.size() == 0 || range.get(1) - range.get(0) > 86400) { // range must be 24 hours or less | ||
| LOGGER.error("Invalid traffic filter rule: {}", ruleJson.encode()); | ||
| throw new MalformedTrafficFilterConfigException("Invalid traffic filter rule"); |
Contributor
There was a problem hiding this comment.
Nitpick: maybe clarify that it must be 24 hours or less, so it’s clear why it’s invalid?
…seline' into ian-UID2-6151-add-traffic-filter-class
caroline-ttd
approved these changes
Dec 4, 2025
…seline' into ian-UID2-6151-add-traffic-filter-class
Ian-Nara
merged commit 8531ec5
into
ian-UID2-6146-update-traffic-calculator-to-hardcoded-baseline
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.