add delta writer, metrics & result classes #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into ian-UID2-6345-add-delta-writer-and-utility-classes
caroline-ttd
approved these changes
Dec 12, 2025
Base automatically changed from
ian-UID2-6345-add-s3-utilities-send-corrupted-to-bucket
to
main
December 12, 2025 02:12
Ian-Nara
deleted the
ian-UID2-6345-add-delta-writer-and-utility-classes
branch
Comment on lines
+105
to
+111
| private void ensureCapacity(int dataSize) { | ||
| if (buffer.capacity() < dataSize) { | ||
| int newCapacity = Integer.highestOneBit(dataSize) << 1; | ||
| LOGGER.info("expanding buffer size: current {}, need {}, new {}", buffer.capacity(), dataSize, newCapacity); | ||
| this.buffer = ByteBuffer.allocate(newCapacity).order(ByteOrder.LITTLE_ENDIAN); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This method is always called with dataSize = OptOutConst.EntrySize. Why don't we remove this method and the ctor's bufferSize param, and initialize buffer with the required capacity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.