UID2-4528 Report faillures on scheduled vulnerability detection runs #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
reviewed
Feb 26, 2025
| default: 'true' | ||
| slack_webhook: | ||
| description: 'The Slack webhook URL for sending messages via incoming webhooks, configured for #dev-uid2-alarms channel' | ||
| required: true |
Contributor
There was a problem hiding this comment.
If we set this to required:true it will break other pipelines using this workflow. Maybe instead provide it with a default value.
cYKatherine
reviewed
Mar 6, 2025
| id: vulnerability-scan | ||
| uses: IABTechLab/uid2-shared-actions/actions/vulnerability_scan@ccm-UID2-4528-report-faillures-on-scheduled-vulnerability-detection-runs # todo change to v3 before merging | ||
| with: | ||
| scan_severity: HIGH,CRITICAL |
Contributor
There was a problem hiding this comment.
Why do we hardcode this to be HIGH,CRITICAL? Let's either use inputs.vulnerability_severity or use an empty string (for it to scan for all the vulnerabilities.
cYKatherine
approved these changes
Mar 7, 2025
caroline-ttd
deleted the
ccm-UID2-4528-report-faillures-on-scheduled-vulnerability-detection-runs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report faillures on scheduled vulnerability detection runs
Although some repos are still using vulnerability_scan_filesystem , that is a history issue . Our goal is utilize vulnerability_scan while eliminating vulnerability_scan_filesystem. To achieve this, I refactored my code to rely solely on vulnerability_scan.
I set up three repository workflows for testing, and they are functioning as expected:
For image action succeeded: MR, Action
For image action failed: MR, Action
For fs action succeeded: MR, Action
Slack message example: