Skip to content

Ans UI d2 4013 make release on sdk release #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleysmithTTD merged 6 commits into from
Jan 30, 2025
Merged

Ans UI d2 4013 make release on sdk release #147

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
411ba39
added section of yml file to publish release notes
ashleysmithTTD Jan 29, 2025
9ee2f4e
creating release workflow
ashleysmithTTD Jan 29, 2025
cb23e32
dont need repo
ashleysmithTTD Jan 29, 2025
ce77993
moved release to after build and added build dependency
ashleysmithTTD Jan 29, 2025
8eaa9ce
directly using softprops release use
ashleysmithTTD Jan 30, 2025
eb89f07
dont need secrets
ashleysmithTTD Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/publish-package-to-npmjs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ jobs:
path: ./dist/euid-sdk-${{ steps.version.outputs.package_version }}.js
outputs:
sdkVersion: ${{ steps.version.outputs.package_version }}
createNpmJsRelease:
id: github_release
uses: IABTechLab/uid2-shared-actions/actions/shared_create_releases@v2
Copy link
Contributor

@lionell-pack-ttd lionell-pack-ttd Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shared action seems to only be for Docker and Maven releases - the main thing this repo is for is the JS SDK. I think the most straight-forward option is to call softprops/action-gh-release directly. Take a look at the last step here: https://github.com/IABTechLab/uid2-shared-actions/blob/v3.20/actions/shared_create_releases/action.yaml

I think if you omit the body parameter you'll get the auto-generated release notes from the included PRs, but I'm not certain - you might need an extra step.

needs: [incrementVersionNumber, build]
with:
is_release: true
new_version: ${{ needs.incrementVersionNumber.outputs.new_version }}
image_tag: ${{ needs.incrementVersionNumber.outputs.image_tag }}
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_platform: Docker
secrets: inherit
publish-package:
if: inputs.publish_to_npm
needs: [build, incrementVersionNumber]
Expand Down