-
Notifications
You must be signed in to change notification settings - Fork 6
react secure signals example site #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react secure signals example site #169
Conversation
| context: examples/google-secure-signals-integration/react_client_side | ||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this all together for now to maintain consistency with what we already had - we'll get rid of this shared example file in a later ticket
| @@ -0,0 +1,33 @@ | |||
| # UID2 React Secure Signals Integration Example | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the first ReadME that has been written for secure signals client side so please review it carefully. will use a version of this to add to UID2 and EUID client side secure signals examples
examples/google-secure-signals-integration/react_client_side/package.json
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,19 @@ | |||
| const ejs = require('ejs'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file actually used for anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, its being used in line 8 to allow HTML rendering
examples/google-secure-signals-integration/react_client_side/public/index.html
Outdated
Show resolved
Hide resolved
examples/google-secure-signals-integration/react_client_side/public/index.html
Outdated
Show resolved
Hide resolved
| setIsUid2Enabled(e.target.checked); | ||
| }; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this into a component and a separate file to organize things a bit?
| }); | ||
| }, []); | ||
|
|
||
| function initializeIMA() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move the google ad event crap to a separate file?
No description provided.