abu-add-kms-usage-explicit #813
Conversation
genwhittTTD
left a comment
genwhittTTD
left a comment
There was a problem hiding this comment.
Left a few small copy comments.
genwhittTTD
left a comment
genwhittTTD
left a comment
There was a problem hiding this comment.
Couple more comments on terms I hadn't understood before... thx.
| | `SSMKeyAlias` | `AWS::KMS::Alias` | An alias that provides an easy way to access the [KMS](https://aws.amazon.com/kms/) key. | | ||
| | `TokenSecret` | `AWS::SecretsManager::Secret` | An encrypted configuration that includes the operator key. | | ||
| | `WorkerRole` | `AWS::IAM::Role` | The IAM role that your UID2 Operators run as. Roles provide access to configuration keys. | | ||
| | `TokenSecret` | `AWS::SecretsManager::Secret` | Secret manager to store the operator key. | |
There was a problem hiding this comment.
Secret manager to store the operator key.
Not sure about this now. Is it the location? The name? Adjust as needed. Suggest:
Location of the AWS Secret Manager for storing the operator key.
There was a problem hiding this comment.
It is not the location,
What about ; "A Secrets Manager secret to store the operator key. " ?
genwhittTTD
left a comment
genwhittTTD
left a comment
There was a problem hiding this comment.
One small mod noted and good to go with that.
| | `TokenSecret` | `AWS::SecretsManager::Secret` | An encrypted configuration that includes the operator key. | | ||
| | `WorkerRole` | `AWS::IAM::Role` | The IAM role that your UID2 Operators run as. Roles provide access to configuration keys. | | ||
| | `TokenSecret` | `AWS::SecretsManager::Secret` | A Secrets Manager secret to store the operator key. | | ||
| | `WorkerRole` | `AWS::IAM::Role` | The IAM role that your UID2 Operators run as. Role provide access to AWS Secrets Manager to retrieve operator keys. | |
There was a problem hiding this comment.
Role provide access to AWS Secrets Manager to retrieve operator keys.
Suggest
The role provides access...
or
Roles provide access...
probably the first.
No description provided.