Skip to content

Fix race condition #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix race condition #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions jpetstore/src/org/springframework/samples/jpetstore/dao/ibatis/SqlMapSequenceDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@ public class SqlMapSequenceDao extends SqlMapClientDaoSupport {
*/
public int getNextId(String name) throws DataAccessException {
Sequence sequence = new Sequence(name, -1);
sequence = (Sequence) getSqlMapClientTemplate().queryForObject("getSequence", sequence);
sequence = (Sequence) getSqlMapClientTemplate().queryForObject("incrementAndReturnModified", sequence);
if (sequence == null) {
throw new DataRetrievalFailureException(
"Could not get next value of sequence '" + name + "': sequence does not exist");
"Could not get next value of sequence '" + name + "': sequence does not exist");
}
Object parameterObject = new Sequence(name, sequence.getNextId() + 1);
getSqlMapClientTemplate().update("updateSequence", parameterObject, 1);
return sequence.getNextId();
}

}

5 changes: 5 additions & 0 deletions jpetstore/src/org/springframework/samples/jpetstore/dao/ibatis/maps/Sequence.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@
update sequence set nextid = #nextId# where name = #name#
</update>

<select id="incrementAndReturnModified" resultMap="result">
update sequence set nextid = nextid + 1 where name = #name# returning name, nextid
</select>

</sqlMap>