-
Notifications
You must be signed in to change notification settings - Fork 20
Remove TLS support #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove TLS support #1006
Conversation
|
See the diff of the files (now deleted) from OpenJCEPlus and the same files in OpenJDK: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other question came to mind here.
Do we know that when JSSE is running in FIPS mode on Semeru does the TLS connections still work? Semeru currently blocks man algorithms in FIPS mode and allows explictly the registration of the algorithms being removed here . Perhaps testing has already been done enabling these algorithms from other locations than OpenJCEPlusFIPS provider.
1b8cc20 to
8b4c676
Compare
|
After removing these TLS key generation services, did you run the OpenJDK tests on Grinder, and do they all look good? |
Removes support for TLS key generation in OpenJCEPlus and OpenJCEPlusFIPS profiles. The internal parameter specs for these classes have been deprecated. Signed-off-by: Sabrina Lee <[email protected]>
8b4c676 to
cac65df
Compare
jasonkatonica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JinhangZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
taoliult
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes support for TLS key generation in OpenJCEPlus and OpenJCEPlusFIPS profiles. The internal parameter specs for these classes have been deprecated.
Signed-off-by: Sabrina Lee [email protected]