Add Check for PQCPrivateKey in Decapsulator and add tests. #1042
+127
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpeck-us-ibm
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
taoliult
Member
jasonkatonica
left a comment
jasonkatonica
left a comment
There was a problem hiding this comment.
Some tests are also failing with the following unused variables:
Error: /home/runner/work/OpenJCEPlus/OpenJCEPlus/src/test/java/ibm/jceplus/junit/base/BaseTestKEM.java:190:16: Unused local variable 'encr'. [UnusedLocalVariable]
Error: /home/runner/work/OpenJCEPlus/OpenJCEPlus/src/test/java/ibm/jceplus/junit/base/BaseTestKEM.java:197:16: Unused local variable 'decr'. [UnusedLocalVariable]
Error: /home/runner/work/OpenJCEPlus/OpenJCEPlus/src/test/java/ibm/jceplus/junit/base/BaseTestKEM.java:208:16: Unused local variable 'encr'. [UnusedLocalVariable]
Error: /home/runner/work/OpenJCEPlus/OpenJCEPlus/src/test/java/ibm/jceplus/junit/base/BaseTestKEM.java:215:16: Unused local variable 'decr'. [UnusedLocalVariable]
jasonkatonica
requested changes
Dec 12, 2025
src/test/java/ibm/jceplus/junit/base/BaseTestPQCKeyInterop.java
Outdated
Show resolved
Hide resolved
src/test/java/ibm/jceplus/junit/base/BaseTestPQCKeyInterop.java
Outdated
Show resolved
Hide resolved
jasonkatonica
requested changes
Dec 12, 2025
jasonkatonica
requested changes
Dec 15, 2025
johnpeck-us-ibm
force-pushed
the
PQCKEMPrivKeyCheck
branch
from
e85ad9f to
990a310
Compare
KostasTsiounis
requested changes
Dec 15, 2025
|
|
||
| PublicKey pubKey = publicKey; | ||
| if (pubKey == null) { | ||
| throw new InvalidKeyException("unsupported key"); |
Member
There was a problem hiding this comment.
Should we change the exception message here, since in this case the key is missing rather than being unsupported?
| PrivateKey privKey = privateKey; | ||
|
|
||
| if (privKey == null) { | ||
| throw new InvalidKeyException("unsupported key"); |
Comment on lines
194
to
210
| // Test null keys | ||
| PublicKey pub = null; | ||
| PrivateKey priv = null; | ||
|
|
||
| try { | ||
| kem.newEncapsulator(pub); | ||
| fail("testKEMKeys failed - NULL Public key did not cause an Invalid Key Excepton."); | ||
| } catch (InvalidKeyException ike) { | ||
| assertTrue(ike.getMessage().equals("unsupported key")); | ||
| } | ||
|
|
||
| try { | ||
| kem.newDecapsulator(priv); | ||
| fail("testKEMKeys failed - NULL Private key did not cause an Invalid Key Excepton."); | ||
| } catch (InvalidKeyException ike) { | ||
| assertTrue(ike.getMessage().equals("unsupported key")); | ||
| } |
Member
There was a problem hiding this comment.
Would it make sense to separate this into another test method?
Member
Author
There was a problem hiding this comment.
It is doing testing of the keys and we really expect the same Exception. So, I don't thing it needs to be broken up.
… keys. Signed-off-by: John Peck <[email protected]>
johnpeck-us-ibm
force-pushed
the
PQCKEMPrivKeyCheck
branch
from
f455242 to
ccf3001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Check for PQCPrivateKey in Decapsulator and add tests for invalid keys.
Signed-off-by: John Peck [email protected]