Tolerate the optional fields in the ECPrivateKey sequence #1057
+126
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinhangZhang
requested review from
KostasTsiounis,
jasonkatonica,
johnpeck-us-ibm and
taoliult
JinhangZhang
force-pushed
the
bugs/eckeyfactory
branch
2 times, most recently
from
0d06ba4 to
5580080
Compare
JinhangZhang
changed the title
JinhangZhang
force-pushed
the
bugs/eckeyfactory
branch
2 times, most recently
from
694bc14 to
345b25f
Compare
jasonkatonica
requested changes
Jan 6, 2026
JinhangZhang
force-pushed
the
bugs/eckeyfactory
branch
2 times, most recently
from
b69779e to
784905d
Compare
jasonkatonica
requested changes
Jan 8, 2026
JinhangZhang
force-pushed
the
bugs/eckeyfactory
branch
from
784905d to
1782e85
Compare
The ECPrivateKey sequence defines two optional fields: parameters and publicKey. When parsing an ECPrivateKey, the code must allow cases where only one of these fields is present, or where both are absent or where both are presented. In addition, it seems that java does not automatically concatenate the cause’s message with the outer exception’s message, the detailed message associated with the cause is not merged into the current exception’s detail message. Therefore, getMessage() is explicitly included when throwing the exception in order to preserve and expose the underlying error details. Signed-off-by: JinhangZhang <[email protected]>
JinhangZhang
force-pushed
the
bugs/eckeyfactory
branch
from
1782e85 to
48ee4e3
Compare
johnpeck-us-ibm
approved these changes
Jan 12, 2026
This was referenced Jan 14, 2026
johnpeck-us-ibm
pushed a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Jan 16, 2026
The ECPrivateKey sequence defines two optional fields: parameters and publicKey. When parsing an ECPrivateKey, the code must allow cases where only one of these fields is present, or where both are absent or where both are presented. In addition, it seems that java does not automatically concatenate the cause’s message with the outer exception’s message, the detailed message associated with the cause is not merged into the current exception’s detail message. Therefore, getMessage() is explicitly included when throwing the exception in order to preserve and expose the underlying error details. Signed-off-by: JinhangZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECPrivateKey sequence defines two optional fields: parameters and publicKey. When parsing an ECPrivateKey, the code must allow cases where only one of these fields is present, or where both are absent or where both are presented.
In addition, it seems that Java does not automatically concatenate the cause’s message with the outer exception’s message, the detailed message associated with the cause is not merged into the current exception’s detail message. Therefore, getMessage() is explicitly included when throwing the exception in order to preserve and expose the underlying error details.