Restrict RSA paddings allowed through OpenJCEPlusFIPS #1122
+64
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds attributes in the RSA service registration in the OpenJCEPlusFIPS provider to only support OAEP paddings. It, also, update the engineSetPadding() method to only allow OAEP paddings to be set when the FIPS provider is used. Tests are updated accordingly to skip invalid padding tests when running with OpenJCEPlusFIPS. A temporary flag that allows the use of other paddings with OpenJCEPlusFIPS is introduced to facilitate migration of users utilizing the previous behaviour. The flag to be set to revert this behaviour is -Dcom.ibm.openjceplusfips.allowNonOAEP=true. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
KostasTsiounis
requested review from
JinhangZhang,
jasonkatonica,
johnpeck-us-ibm and
taoliult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds attributes in the RSA service registration in the
OpenJCEPlusFIPSprovider to only support OAEP paddings.It, also, update the
engineSetPadding()method to only allow OAEP paddings to be set when the FIPS provider is used.Tests are updated accordingly to skip invalid padding tests when running with
OpenJCEPlusFIPS.A temporary flag that allows the use of other paddings with
OpenJCEPlusFIPSis introduced to facilitate migration of users utilizing the previous behaviour. The flag to be set to revert this behaviour is-Dcom.ibm.openjceplusfips.allowNonOAEP=true.Back-ported from: #1036
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com