Refactor JUnit 5 for BaseTestAESCopySafe and BaseTestAESGCMLong tests#1233
Refactor JUnit 5 for BaseTestAESCopySafe and BaseTestAESGCMLong tests#1233Mohit-Rajbhar100698 wants to merge 1 commit intoIBM:mainfrom
Conversation
Mohit-Rajbhar100698
force-pushed
the
mohit/junit5-basetestaescopysafe-gcmlong
branch
from
9704faa to
1ec2316
Compare
This change consolidates the tests previously associated with BaseTestAESCopySafe into the parameterized TestAESCopySafe class, and the tests from BaseTestAESGCMLong into the parameterized TestAESGCMLong class. Fixes: https://github.ibm.com/runtimes/jit-crypto/issues/1097 Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
mohit/junit5-basetestaescopysafe-gcmlong
branch
from
1ec2316 to
e94765a
Compare
|
|
||
| package ibm.jceplus.junit.tests; | ||
|
|
||
| public class BaseUtils { |
There was a problem hiding this comment.
I think the class should be named TestUtils, since the Test* classes will be using it now.
There was a problem hiding this comment.
If we change the class name to TestUtils, we’ll have to update it everywhere, wherever BaseUtils(to TestUtils) is used, which means a lot of small changes going further in test classes.
Also, this class is just for utility methods, not an actual test class, so if we keep current name changes can be less.
As we are using same name for BaseTestCipher
But if everyone agrees, I’m okay with renaming it.
There was a problem hiding this comment.
I do agree that the name TestUtils seems better but I think you make a good point here Mohit that doing this will pollute the clean migration we are trying to do ( as clean as we can ). For now seems like it would be easier to create a new BaseUtils class then we can rename this class after everything is converted to make it TestUtils.
3 participants
This change consolidates the tests previously associated with BaseTestAESCopySafe into the parameterized TestAESCopySafe class, and the tests from BaseTestAESGCMLong into the parameterized TestAESGCMLong class.
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com