Use shorter message to avoid error in RSA/ECB/NoPadding benchmark#1241
Open
KostasTsiounis wants to merge 1 commit intoIBM:java25from
Open
Use shorter message to avoid error in RSA/ECB/NoPadding benchmark#1241KostasTsiounis wants to merge 1 commit intoIBM:java25from
KostasTsiounis wants to merge 1 commit intoIBM:java25from
Conversation
The message needs to be smaller than the key not just in number of bytes, but in absolute bitwise value. Having the key and message be the exact same number of bytes (when no padding is added) and be created randomly leads to cases where this condition does not apply and the operations fail. To ensure that this doesn't happen, we make the message one byte smaller. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
KostasTsiounis
requested review from
JinhangZhang,
jasonkatonica,
johnpeck-us-ibm and
taoliult
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message needs to be smaller than the key not just in number of bytes, but in absolute bitwise value. Having the key and message be the exact same number of bytes (when no padding is added) and be created randomly leads to cases where this condition does not apply and the operations fail.
To ensure that this doesn't happen, we make the message one byte smaller.
Back-ported from: #1227
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com