feat: configurable ecdsa curve and support secp256k1#45
Open
LanfordCai wants to merge 2 commits intoIBM:mainfrom
Open
feat: configurable ecdsa curve and support secp256k1#45LanfordCai wants to merge 2 commits intoIBM:mainfrom
LanfordCai wants to merge 2 commits intoIBM:mainfrom
Conversation
LanfordCai
force-pushed
the
feature/configurable_ecdsa_curve
branch
from
2bf1e67 to
581781f
Compare
yacovm
reviewed
Dec 28, 2024
| @@ -108,9 +109,9 @@ func (parties parties) Mapping() map[string]*tss.PartyID { | |||
| } | |||
|
|
|||
| func TestTSS(t *testing.T) { | |||
Contributor
There was a problem hiding this comment.
we should add another test which initializes it with secp256k1.
Perhaps add a loop that iterates over both curve options?
Author
There was a problem hiding this comment.
I have added a loop to iterate over the curves
yacovm
reviewed
Dec 28, 2024
test/binance/ecdsa_test.go
Outdated
| verifySig = verifySignatureECDSA | ||
| signatureAlgorithms = ecdsaKeygenAndSign | ||
| signatureAlgorithms = func(loggers []*commLogger) (func(uint16) KeyGenerator, func(uint16) Signer) { | ||
| return ecdsaKeygenAndSign(elliptic.P256(), loggers) |
Contributor
There was a problem hiding this comment.
same thing, let's have a test case which initializes an instance with secp256k1.
Author
There was a problem hiding this comment.
I have added a loop to iterate over the curves
Signed-off-by: lanford33 <lanfordcai@outlook.com>
Signed-off-by: lanford33 <lanfordcai@outlook.com>
LanfordCai
force-pushed
the
feature/configurable_ecdsa_curve
branch
from
29e6d04 to
2657fed
Compare
yacovm
reviewed
Dec 29, 2024
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace github.com/IBM/TSS/mpc/binance/ecdsa => ../mpc/binance/ecdsa |
Contributor
There was a problem hiding this comment.
no, let's not do this.
You can make a change to the mpc/binance/ecdsa package in this PR, and then wait for this PR to be merged, and then make a new PR that would just take the latest version into the go.mod of the test module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for different elliptic curves in the
mpc/binance/ecdsapackage. The changes primarily involve modifying thepartystruct and related methods to accept and utilize an elliptic curve parameter. Additionally, the test files are updated to accommodate these changes.