Skip to content

Fix issue with more than 2 plugins listed #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fryguy merged 1 commit into from
Nov 18, 2025
Merged

Fix issue with more than 2 plugins listed #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,12 @@ jobs:
- name: Set up ibmcloud CLI
uses: ./
with:
plugins: container-service,secrets-manager
plugins: container-service,secrets-manager,cr
- name: Check plugins are installed
run: |
ibmcloud plugin list | grep -q '^container-service\b' &&
ibmcloud plugin list | grep -q '^secrets-manager\b'
ibmcloud plugin list | grep -q '^secrets-manager\b' &&
ibmcloud plugin list | grep -q '^container-registry\b'

test-multiple-plugins-with-comma-space:
runs-on: ubuntu-latest
Expand All @@ -78,11 +79,12 @@ jobs:
- name: Set up ibmcloud CLI
uses: ./
with:
plugins: container-service, secrets-manager
plugins: container-service, secrets-manager, cr
- name: Check plugins are installed
run: |
ibmcloud plugin list | grep -q '^container-service\b' &&
ibmcloud plugin list | grep -q '^secrets-manager\b'
ibmcloud plugin list | grep -q '^secrets-manager\b' &&
ibmcloud plugin list | grep -q '^container-registry\b'

test-multiple-plugins-with-newlines:
runs-on: ubuntu-latest
Expand All @@ -94,10 +96,12 @@ jobs:
plugins: |
container-service
secrets-manager
cr
- name: Check plugins are installed
run: |
ibmcloud plugin list | grep -q '^container-service\b' &&
ibmcloud plugin list | grep -q '^secrets-manager\b'
ibmcloud plugin list | grep -q '^secrets-manager\b' &&
ibmcloud plugin list | grep -q '^container-registry\b'

test-multiple-plugins-with-spaces:
runs-on: ubuntu-latest
Expand All @@ -106,11 +110,12 @@ jobs:
- name: Set up ibmcloud CLI
uses: ./
with:
plugins: container-service secrets-manager
plugins: container-service secrets-manager cr
- name: Check plugins are installed
run: |
ibmcloud plugin list | grep -q '^container-service\b' &&
ibmcloud plugin list | grep -q '^secrets-manager\b'
ibmcloud plugin list | grep -q '^secrets-manager\b' &&
ibmcloud plugin list | grep -q '^container-registry\b'

test-multiple-plugins-with-versions:
runs-on: ubuntu-latest
Expand All @@ -119,11 +124,12 @@ jobs:
- name: Set up ibmcloud CLI
uses: ./
with:
plugins: [email protected], secrets-manager
plugins: [email protected], secrets-manager, [email protected]
- name: Check plugins are installed
run: |
ibmcloud plugin list | grep -q '^container-service\b.\+0\.4\.102\b' &&
ibmcloud plugin list | grep -q '^secrets-manager\b'
ibmcloud plugin list | grep -q '^secrets-manager\b' &&
ibmcloud plugin list | grep -q '^container-registry\b.\+1\.3\.\b'

test-multiple-plugins-with-versions-and-newlines:
runs-on: ubuntu-latest
Expand All @@ -135,10 +141,12 @@ jobs:
plugins: |
[email protected]
secrets-manager
[email protected]
- name: Check plugins are installed
run: |
ibmcloud plugin list | grep -q '^container-service\b.\+0\.4\.102\b' &&
ibmcloud plugin list | grep -q '^secrets-manager\b'
ibmcloud plugin list | grep -q '^secrets-manager\b' &&
ibmcloud plugin list | grep -q '^container-registry\b.\+1\.3\.\b'

test-login:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function captureVersion() {
}

async function installPlugins() {
const plugins = core.getInput('plugins').replace('\n', ' ').replace(',', ' ').split(' ').map(p => p.trim()).filter(p => p)
const plugins = core.getInput('plugins').replace(/\n/g, ' ').replace(/,/g, ' ').split(' ').map(p => p.trim()).filter(p => p)
if (plugins.length > 0) {
core.startGroup('Installing IBM Cloud CLI plugins')
await exec.exec('ibmcloud', ['plugin', 'install', ...plugins])
Expand Down
Loading