Restructure Helm chart output directories #2360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YCShen1010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: YuChen <[email protected]>
YCShen1010
force-pushed
the
helm-restructure
branch
from
9ee6ad3 to
d96d0f8
Compare
Signed-off-by: YuChen <[email protected]>
Signed-off-by: YuChen <[email protected]>
Signed-off-by: YuChen <[email protected]>
YCShen1010
force-pushed
the
helm-restructure
branch
from
e94c1b4 to
f1eb733
Compare
Signed-off-by: YuChen <[email protected]>
YCShen1010
force-pushed
the
helm-restructure
branch
from
a4dc095 to
da38a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
helm-restructurescript is added intoMakefileand organizes Helm output into separate directories forcluster-scopedandnon-cluster-scopedresources. It merges related YAML files with---separators and ensures required resources (Role, RoleBinding, ServiceAccount) are properly categorizedWhich issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65718
How the test
helmandhelm-cluster-scopemake helmhelmandhelm-cluster-scopewill be generated again