Skip to content

Review changes from scripts-dev to scripts-adopter#2413

Merged
github-actions[bot] merged 1 commit intoscripts-adopterfrom
scripts-dev
Feb 28, 2025
Merged

Review changes from scripts-dev to scripts-adopter#2413
github-actions[bot] merged 1 commit intoscripts-adopterfrom
scripts-dev

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Feb 28, 2025

common service installer automation on 2025-02-28-14-47-02

@bluzarraga
Add restore-nss.yaml file (#2412)
12c9473 
* add common-web-ui-config cm to labeling script

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>

* update for helm chart BR

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>

* add restore-nss.yaml file

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>

---------

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
@github-actions
Copy link
Author

github-actions bot commented Feb 28, 2025

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot
Copy link
Contributor

ibm-ci-bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign daniel-fan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot
Copy link
Contributor

ibm-ci-bot commented Feb 28, 2025

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qpdpQ
Copy link
Contributor

qpdpQ commented Feb 28, 2025 •
edited
Loading

/ok-to-sync

@github-actions github-actions bot merged commit 12c9473 into scripts-adopter Feb 28, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitscuit bitscuit Awaiting requested review from bitscuit

@bluzarraga bluzarraga Awaiting requested review from bluzarraga

Assignees

No one assigned

Labels

needs-ok-to-test ok-to-sync size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibm-ci-bot @qpdpQ @bluzarraga