Conversation
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
|
Trying to intergrate it with br automation now |
bluzarraga
left a comment
There was a problem hiding this comment.
This mostly comes down to labeling semantics. The label-common-service.sh script is not on the same page as some of the recipes here creating some gaps. Let's make sure to get on the same page as the script since other items are already based on how the script labels them
velero/spectrum-fusion/recipes/no-olm/core/child-zen-recipe-2.10.0.yaml
Outdated
Show resolved
Hide resolved
velero/spectrum-fusion/recipes/no-olm/core/child-cs-odlm-chart-recipe.yaml
Show resolved
Hide resolved
velero/spectrum-fusion/recipes/no-olm/core/child-cs-odlm-chart-recipe.yaml
Show resolved
Hide resolved
velero/spectrum-fusion/recipes/no-olm/core/child-cs-odlm-chart-recipe.yaml
Show resolved
Hide resolved
velero/spectrum-fusion/recipes/no-olm/core/child-im-ui-chart-recipe.yaml
Outdated
Show resolved
Hide resolved
|
We also need to update this spot here . No olm is supposed to be able to work without namespace scope but currently some key resources require an nss specific resource to be present to determine their namespace. We need some kind of no olm/no nss friendly way to determine these namespaces. Should just be a combination of op, services, and tethered namespaces though (plus the singleton namespaces like we already do) |
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
bluzarraga
left a comment
There was a problem hiding this comment.
Changes to the recipe look good. We don't want to increase the permissions of the label-common-service.sh script though because of the attached job so lets rethink how we grab the namespaces
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
|
This looks good to me now, thanks @qpdpQ |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bluzarraga, qpdpQ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



What this PR does / why we need it:
fusion recipe for no-olm cpfs services, including cs-operator, odlm, im, ui, edb and zen
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/67407