[SC2] ODLM channel check enhancement#2643
Merged
Daniel-Fan merged 5 commits intoIBM:release-sc2from Oct 16, 2025
Merged
Conversation
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Daniel-Fan
requested changes
Oct 6, 2025
Daniel-Fan
requested changes
Oct 6, 2025
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Daniel-Fan
requested changes
Oct 14, 2025
Contributor
Daniel-Fan
left a comment
Daniel-Fan
left a comment
There was a problem hiding this comment.
Hi @qpdpQ
Could you please review the comments in #2633 (review) and make the changes? Thank you!
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Daniel-Fan
approved these changes
Oct 16, 2025
Contributor
Daniel-Fan
left a comment
Daniel-Fan
left a comment
There was a problem hiding this comment.
Thank you @qpdpQ
The checks for ODLM channel in PackageManifest look great!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Daniel-Fan, qpdpQ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
cherry-pick from #2633
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/67333