Skip to content

Add additional values field to migration chart for CPD use case#2716

Closed
bluzarraga wants to merge 3 commits intoIBM:masterfrom
bluzarraga:cpd-70357
Closed

Add additional values field to migration chart for CPD use case#2716
bluzarraga wants to merge 3 commits intoIBM:masterfrom
bluzarraga:cpd-70357

Conversation

@bluzarraga
Copy link
Member

What this PR does / why we need it: CPD noted a scenario where Argo can pull from the wrong repository (specifically trying to pull from the premium repo instead of the free and vice versa)

Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/PrivateCloud-analytics/CPD-Quality/issues/70357

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
@ibm-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bluzarraga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
@bluzarraga
Copy link
Member Author

Verified that the new logic works as expected. New priority list is as follows:

  1. Values.global.installConfigImagePullPrefix
  2. Values.cpfs.imagePullPrefix
  3. Values.global.imagePullPrefix

@bluzarraga bluzarraga changed the title [WIP] Add additional values field to migration chart for CPD use case Add additional values field to migration chart for CPD use case Jan 7, 2026
Copy link

@mandymchu mandymchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change needed is the migration chart version
the third digit of the migration chart version has to be incremented

@Daniel-Fan
Copy link
Contributor

Close as no longer needed

@Daniel-Fan Daniel-Fan closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants