Make roksEnabled default to true in Helm#2749
Merged
qpdpQ merged 1 commit intoIBM:masterfrom Feb 24, 2026
Merged
Conversation
…aml used is different Signed-off-by: Jeremy Cheng <jeremyjcheng@gmail.com>
Contributor
|
This makes sure the the value in |
qpdpQ
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the case that
.Values.cpfs.roksEnableddoesn't exist, we will make roksEnabled default to true inside the template. The case whereroksEnableddoesn't exist can happen if the values.yaml that's with the template is not used. If the value doesn't exist, it defaults to nil and can cause errors. Adding for safety.