single stage operandconfig creation

[qpdpQ]

What this PR does / why we need it:
CS operator previously created template OperandConfig first, then updated it with CommonService CR values. The time gap between creation and update caused race conditions with ODLM reconciliation.

This pr will merge all configurations before first OperandConfig creation, eliminating the incomplete intermediate state.

Benefits:
Single OperandConfig creation with complete configuration
No race conditions with ODLM
Reduced API calls: 2 → 1 per reconciliation
Faster time to desired state
Cleaner reconciliation logic

Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/68806

[qpdpQ]

test log:

I0226 21:19:53.781002 1 no_olm_commonservice_controller.go:160] Start to Create ODLM CR in the namespace helm
I0226 21:19:53.781018 1 no_olm_commonservice_controller.go:167] Checking if OperandRegistry and OperandConfig CRD already exist
I0226 21:19:57.836620 1 request.go:697] Waited for 1.043097276s due to client-side throttling, not priority and fairness, request: GET:https://172.30.0.1:443/apis/ingress.operator.openshift.io/v1?timeout=32s
I0226 21:19:59.788838 1 no_olm_commonservice_controller.go:172] Installing/Updating OperandRegistry
I0226 21:19:59.829552 1 operandregistry.go:185] Updating OperandRegistry helm/common-service
I0226 21:19:59.861003 1 no_olm_commonservice_controller.go:178] Installing/Updating OperandConfig
I0226 21:19:59.924831 1 init.go:991] Merging CommonService configurations with base OperandConfig
I0226 21:19:59.924887 1 config_extractor.go:193] Extracting size configuration
I0226 21:19:59.932646 1 config_merger.go:39] Merging base OperandConfig with CommonService configurations
I0226 21:20:00.113268 1 config_merger.go:101] Successfully merged CommonService configurations with base OperandConfig
I0226 21:20:00.113341 1 init.go:998] Successfully merged configurations for single-stage OperandConfig creation
I0226 21:20:00.221385 1 init.go:664] Updating resource with name: common-service, namespace: helm, kind: OperandConfig, apiversion: operator.ibm.com/v1alpha1

[Daniel-Fan]

Hi @qpdpQ
Could you please add some unit tests for this OperandConfig merger and validator?
This is a good reference on how to write effective test cases. https://dev.to/litmus-chaos/strategies-for-writing-more-effective-tests-in-golang-1fma

Thank you!

Found issue with non olm controller

[Daniel-Fan]

Hi @qpdpQ
Would you please review the changes for non OLM controller?

I saw that the changes for OLM controller is much more than the changes in non-OLM controller. Is there any redundant code that we could remove from non-OLM controller?

Thank you!

[qpdpQ]

nice catch, I forgot to apply the same change in no-olm controller, just applied them

[Daniel-Fan]

Thank you for the changes @qpdpQ

They are all looking good to me!