Add additional secrets deletion in uninstall script#2756
Merged
Daniel-Fan merged 1 commit intoIBM:scripts-devfrom Mar 2, 2026
Merged
Add additional secrets deletion in uninstall script#2756Daniel-Fan merged 1 commit intoIBM:scripts-devfrom
Daniel-Fan merged 1 commit intoIBM:scripts-devfrom
Conversation
Daniel-Fan
approved these changes
Mar 2, 2026
Contributor
Daniel-Fan
left a comment
There was a problem hiding this comment.
Thanks @qpdpQ
It looks good to me to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The uninstall script removes the cs-ca-certificate but does not remove the existing leaf-certificate secrets. As a result, if a user reinstalls the product in the same namespace, the cs-operator creates a new cs-ca-certificate, but cert-manager will continue reusing the old leaf-certificate secrets because they are still considered valid.
Since these leaf-certificate secrets were created before the leaf-certificate was issued, the cs-operator unable to find them so does not refresh them during reconciliation. This leads to a certificate mismatch between the newly generated CA certificate and the old leaf certificates, ultimately causing TLS validation failures.
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/PrivateCloud-analytics/CPD-Quality/issues/60029