Skip to content

Replace echo -e and echo -n with printf for macOS compatibility #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel-Fan merged 2 commits into from
Mar 4, 2026
Merged

Replace echo -e and echo -n with printf for macOS compatibility #2759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08be91a
Replace echo with printf for hostname processing in DNS configuration
YCShen1010 Mar 2, 2026
0f0e9fb
use printf for print_usage function
YCShen1010 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions checker_tool/check_cpfs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@ function print_usage() {
echo "Usage: ${script_name} [OPTIONS]..."
echo ""
echo "Accepted cli arguments are:"
echo -e "\t[--help|-h], prints this help."
echo -e "\t[--all|-a], all cases will be ran."
echo -e "\t[--groups|-g <groups>], the case groups should be like --groups='group1,group2'."
echo -e "\t[--groups|-g -l], list the current supported groups."
echo -e "\t[--ignore-groups|-ng <groups>], skip the cases groups, like -ng group1,group2."
echo -e "\t[--cases|-c <cases>], the cases should be like --cases='case1,case2'."
echo -e "\t[--cases|-c -l], list the current supported cases."
echo -e "\t[--ignore-cases|-nc <cases>], skip the cases groups, like -nc case1,case2."
echo -e "\t[--output-file|-f <string>], name to use for the output file. Default name is 'results.json'"
printf '%b\n' "\t[--help|-h], prints this help."
printf '%b\n' "\t[--all|-a], all cases will be ran."
printf '%b\n' "\t[--groups|-g <groups>], the case groups should be like --groups='group1,group2'."
printf '%b\n' "\t[--groups|-g -l], list the current supported groups."
printf '%b\n' "\t[--ignore-groups|-ng <groups>], skip the cases groups, like -ng group1,group2."
printf '%b\n' "\t[--cases|-c <cases>], the cases should be like --cases='case1,case2'."
printf '%b\n' "\t[--cases|-c -l], list the current supported cases."
printf '%b\n' "\t[--ignore-cases|-nc <cases>], skip the cases groups, like -nc case1,case2."
printf '%b\n' "\t[--output-file|-f <string>], name to use for the output file. Default name is 'results.json'"
echo ""
}

Expand Down
4 changes: 2 additions & 2 deletions preload_data.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ data:

[alt_names]

DNS.1 = \$(echo -n "\$my_hostname" | sed s/-[0-9]*\$//)
DNS.1 = \$(printf '%s' "\$my_hostname" | sed s/-[0-9]*\$//)

DNS.2 = \$my_hostname

Expand Down Expand Up @@ -1536,7 +1536,7 @@ data:

[alt_names]

DNS.1 = \$(echo -n "\$my_hostname" | sed s/-[0-9]*\$//)
DNS.1 = \$(printf '%s' "\$my_hostname" | sed s/-[0-9]*\$//)

DNS.2 = \$my_hostname

Expand Down