Fix resource loss during CS merge and improve OperandConfig creation#2762
Merged
qpdpQ merged 11 commits intoIBM:masterfrom Mar 6, 2026
Merged
Fix resource loss during CS merge and improve OperandConfig creation#2762qpdpQ merged 11 commits intoIBM:masterfrom
qpdpQ merged 11 commits intoIBM:masterfrom
Conversation
… checks and CPU limit clearing.
…ssing by introducing helper functions for map access and string field extraction.
… ordering and append CS-only resources.
…a new `convertServiceConfigs` helper function.
…rating the object list and calling `ExtractCommonServiceConfigs`.
…f through the CommonServiceReconciler.
… feature extraction, invalid base configuration, and namespace handling.
qpdpQ
approved these changes
Mar 6, 2026
Contributor
qpdpQ
left a comment
qpdpQ
left a comment
There was a problem hiding this comment.
pr looks good to me, thank you @Daniel-Fan !
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
configMergerfrom package-level variable toBootstrapstruct field for thread safety.convertServiceConfigshelper.MergeConfigsa pure function that accepts servicesNs directly instead of reading it from the reconciler.Migrate
getExtremeizesto useExtractCommonServiceConfigs, removing unnecessary typed-to-unstructured round-trip.mergeResourceArraysandMergeConfigsWhich issue(s) this PR fixes:
Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/68916