[DNM]consume ldap bindpwd and external edb certs SPCs #1051
+329
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tirumalavasa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tirumalavasa
changed the title
pgodowski
reviewed
Jun 9, 2025
| @@ -382,7 +383,8 @@ func (r *AuthenticationReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| Watches(&corev1.Service{}, handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &operatorv1alpha1.Authentication{}, handler.OnlyControllerOwner())). | |||
| Watches(&netv1.Ingress{}, handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &operatorv1alpha1.Authentication{}, handler.OnlyControllerOwner())). | |||
| Watches(&appsv1.Deployment{}, handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &operatorv1alpha1.Authentication{}, handler.OnlyControllerOwner())). | |||
| Watches(&autoscalingv2.HorizontalPodAutoscaler{}, handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &operatorv1alpha1.Authentication{}, handler.OnlyControllerOwner())) | |||
| Watches(&autoscalingv2.HorizontalPodAutoscaler{}, handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &operatorv1alpha1.Authentication{}, handler.OnlyControllerOwner())). | |||
| Watches(&sscsidriverv1.SecretProviderClass{}, handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &operatorv1alpha1.Authentication{}, handler.OnlyControllerOwner())) | |||
There was a problem hiding this comment.
shouldn't this be conditional, only if SSCSI driver installed?
controllers/operator/deployment.go
Outdated
| spc := &sscsidriverv1.SecretProviderClass{} | ||
| if ctrlcommon.ClusterHasCSIGroupVersion(&r.DiscoveryClient) { | ||
| reqLogger.Info("TML:: SPC object found") | ||
| err := r.Client.Get(ctx, types.NamespacedName{Name: spcName, Namespace: namespace}, spc) |
There was a problem hiding this comment.
In the spec, it was defined that the lookup of SPC CR is by the label-based lookup, not based on the name. I like though lookup by name - it's more prescriptive and less error prone (e.g. multiple SPC CRs with the same labels in the same namespace)
controllers/operator/deployment.go
Outdated
| err := r.Client.Get(ctx, types.NamespacedName{Name: spcName, Namespace: namespace}, spc) | ||
| return err == nil | ||
| } | ||
| reqLogger.Info("TML:: SPC object not-found") |
There was a problem hiding this comment.
pls cleanup logging before submitting the PR
Tirumalavasa
changed the title
Tirumalavasa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.ibm.com/IBMPrivateCloud/roadmap/issues/66808