Hardening: safer CORS config + localhost bind defaults#2767
Open
TheodorNEngoy wants to merge 2 commits intoIBM:mainfrom
Open
Hardening: safer CORS config + localhost bind defaults#2767TheodorNEngoy wants to merge 2 commits intoIBM:mainfrom
TheodorNEngoy wants to merge 2 commits intoIBM:mainfrom
Conversation
Signed-off-by: Theodor N. Engøy <theodornengoy@Mac.home>
722d4c0 to
2850c4a
Compare
Member
|
Thanks for this hardening PR, @TheodorNEngoy! Solid security improvements:
A couple of minor suggestions:
Neither is a blocker. LGTM! |
Signed-off-by: Theodor N. Engøy <theodornengoy@eduroam-193-157-246-146.wlan.uio.no>
Author
|
Thanks! Addressed both nits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hardens the LangChain agent runtime defaults to avoid two common security footguns for network-exposed MCP-adjacent servers:
CORS_ORIGINS=*with credentials. The app now readsCORS_ORIGINS/CORS_CREDENTIALSand forces credentials off whenCORS_ORIGINS=*(with a warning), since wildcard+credentials is unsafe.127.0.0.1instead of0.0.0.0inMakefileandstart_agent.py(still configurable viaHOST/PORT). The containerDockerfileremains--host 0.0.0.0.Also updates
.env.exampleto reflect safer defaults (CORS disabled by default; loopback bind by default).Rationale: reduces accidental remote exposure + credentialed cross-origin access while keeping intentional remote deployments opt-in.