refactor: restructure Rust plugins as independent crates#2915
Open
refactor: restructure Rust plugins as independent crates#2915
Conversation
670688b to
1386838
Compare
Collaborator
Author
|
@crivetimihai ready for review |
Remove workspace-level Cargo.toml and make each Rust plugin a standalone crate with its own build configuration. This simplifies plugin development by eliminating workspace dependencies and allowing plugins to be built, tested, and distributed independently. Signed-off-by: lucarlig <luca.carlig@ibm.com>
Update Containerfiles, Makefile, CI workflow, and documentation to reflect the removal of the workspace-level Cargo.toml. Each Rust plugin is now built independently by iterating over plugin subdirectories instead of relying on a workspace root. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
1386838 to
dc93645
Compare
Member
Review & RebaseRebased onto main (was 44 commits behind) and added a fix commit to address broken references from the restructuring. What was fixedThe original commit correctly restructured
Performance claimReverted "5-100x" back to "5-10x" — the benchmark data (which was removed from the docs) showed 6.7x-8.3x speedups. Commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2730
Remove workspace-level Cargo.toml and make each Rust plugin a standalone crate with its own build configuration. This simplifies plugin development by eliminating workspace dependencies and allowing plugins to be built, tested, and distributed independently.
Each plugin now has:
Cargo.tomlwith independent dependenciesMakefilefor standalone buildspyproject.tomlfor Python bindingsThis change reduces complexity and makes it easier to add new Rust plugins without affecting existing ones.