fix: Handle Empty String in iFrame Embedding Config options#2958
Open
prakhar-singh1928 wants to merge 2 commits intomainfrom
Open
fix: Handle Empty String in iFrame Embedding Config options#2958prakhar-singh1928 wants to merge 2 commits intomainfrom
prakhar-singh1928 wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #2492
📝 Summary
This PR fixes X_FRAME_OPTIONS related middleware behavior not properly handling empty string values.
Key changes:
""was falling through to the default case and being treated like DENY (addingframe-ancestors 'none'), when it should allow all embedding (no frame-ancestors directive)test_security_middleware_comprehensive.pyto useNoneinstead of""when testing disabled iframe restrictions, matching the config validator's behavior that converts empty strings toNoneThe root cause was:
""as an unknown value, defaulting to DENY behavior(adding frame-ancestors 'none') (blocking embedding)All X_FRAME_OPTIONS now exhibit expected behaviour
🏷️ Type of Change
🧪 Verification
✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Targeted local verification executed:
pytest tests/unit/mcpgateway/test_config.py -v✅pytest tests/security/test_security_middleware_comprehensive.py✅