fix: use plugin_dirs config to resolve external plugins (#2935)#2959
Open
fix: use plugin_dirs config to resolve external plugins (#2935)#2959
Conversation
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>
6ba484a to
77163c0
Compare
Contributor
Author
|
All Python tests and coverage checks pass on both py3.11 and py3.12. The only failing check is linting-full, which seems to be a Helm unittest plugin installation issue unrelated to this PR. Let me know if anything needs to be changed! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #2935
📝 Summary
The plugin_dirs config field in plugins/config.yaml was never used by the plugin
manager. External plugins in custom directories failed to load because their paths were
not added to sys.path before importlib.import_module() was called.
This PR adds the configured plugin_dirs to sys.path during PluginManager.initialize()
and cleans them up on shutdown() and reset().
🏷️ Type of Change
🧪 Verification
Command: pytest tests/unit/mcpgateway/plugins/framework/test_manager.py -v
Status: 13/13 passed
✅ Checklist
📓 Notes (optional)
tests or restarts