fix: Support APP_ROOT_PATH for static file serving #858
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When APP_ROOT_PATH is set (e.g., /gateway), static files are now correctly
mounted at the appropriate path (e.g., /gateway/static) to work with
reverse proxy configurations.
- Mount static files at {APP_ROOT_PATH}/static when APP_ROOT_PATH is set
- Keep default /static mount when APP_ROOT_PATH is not set
- Update logging to show the actual static mount path
This fixes 404 errors when accessing admin.css and other static assets
in reverse proxy deployments.
Signed-off-by: ESnark <[email protected]>
ESnark
force-pushed
the
fix/static-path
branch
from
23ef6f7 to
ffa9d1d
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Before opening this PR please:
make lint- passesruff,mypy,pylintmake test- all unit + integration tests greenmake coverage- ≥ 90 %make docker docker-run-sslormake podman podman-run-ssl📌 Summary
This PR fixes static file serving when APP_ROOT_PATH is configured, ensuring that static assets (CSS, JS) are correctly
mounted and accessible when the application is deployed behind a reverse proxy with a custom base path.
🔁 Reproduction Steps
🐞 Root Cause
When APP_ROOT_PATH was configured for reverse proxy deployments, static files were still mounted at /static instead of {APP_ROOT_PATH}/static, causing the browser to request assets at the wrong path and resulting in 404 errors.
💡 Fix Description
Modified the static file mounting logic to:
🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)